[Bug 1853888] Review Request: libLTK - Ladspa v3 ToolKit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1853888



--- Comment #9 from Lewis <anesa.lewis@xxxxxxxxx> ---
Hi,

I took Robert-André Mauchin's advices in account.

Here is the new srpm and spec files :
https://copr-be.cloud.fedoraproject.org/results/lewisanesa/CodeColla/fedora-32-x86_64/01554976-LTK/LTK-1.6.3-14.fc32.src.rpm
https://copr-be.cloud.fedoraproject.org/results/lewisanesa/CodeColla/fedora-32-x86_64/01554976-LTK/LTK-1.6.3-14.spec

Now it generates libLTK.so.1 and
libLTK.so -> libLTK.so.1
libLTK.so.1.6.3 -> libLTK.so.1

But I still have three questions :
Why not do libLTK.so -> libLTK.so.1 -> libLTK.so.1.6.3 links?
Shouldn't my package be dependent of libunwind? what if libunwind evolves?
How can I change the line "rpmbuild -D "_topdir $(pwd)" -ba $SPEC_FILE"
in order to use fedpkg or mock or whatever I have to use?
(This line is in the over engineered auto script make.sh at the root of
git://codecolla.com/libltk)

I said :
> For non french speaking people, I'll recap changes made to fit fedora requirements, may this help someone one day...

- Added a MAJOR global definition in the specfile
- Commented and corrected Source0
- Added empty line management in dependencies
- Switched %prep to %autosetup
- Added intermediate shared object file with only major in name
- Added it to soname on gcc final output
- Gathered together install files and managed multi section manpages
- Added link layer to proper tarball creation
- Added fedora's compil flags
- Removed libunwind dependency (libunwind-devel build dep is enough)
- Added constant strings to sprintf calls (fedora flags compatibility)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux