Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: perl-XML-LibXML-Common https://bugzilla.redhat.com/show_bug.cgi?id=226286 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-10-26 00:35 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 13b6d93f53375d15fd11922216249659 XML-LibXML-Common-0.13.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs PERL_DL_NONLAZY=1 /usr/bin/perl "-Iblib/lib" "-Iblib/arch" test.pl 1..8 # Running under perl version 5.008008 for linux # Current time local: Fri Oct 26 00:20:39 2007 # Current time GMT: Fri Oct 26 04:20:39 2007 # Using Test.pm version 1.25 ok 1 ok 2 ok 3 ok 4 ok 5 ok 6 ok 7 ok 8 + Package perl-XML-LibXML-Common-0.13-10.fc8 -> Provides: Common.so perl(XML::LibXML::Common) = 0.13 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libm.so.6 libpthread.so.0 libpthread.so.0(GLIBC_2.0) libxml2.so.2 libz.so.1 perl(:MODULE_COMPAT_5.8.8) perl(DynaLoader) perl(Exporter) perl(constant) perl(strict) perl(vars) rtld(GNU_HASH) APPROVED. You can CLOSE this review as reviewed package is already built in rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review