Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-packagekit - gnome applications for PackageKit https://bugzilla.redhat.com/show_bug.cgi?id=333471 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-10-26 00:32 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. dfd4118a5980bac647660491fcc3698a gnome-packagekit-0.1.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is small so no need of -doc subpackage. + BuildRequires are proper. + Compiler flags are honoured correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc files are present. + no -devel subpackage exists. + no .la files. + translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + scrollkeeper, Gconf, update-dekstop-database, update-gtk-icon-cache scriptlets are used. + package gnome-packagekit-0.1.1-1.fc8 -> Provides: config(gnome-packagekit) = 0.1.1-1.fc8 Requires: config(gnome-packagekit) = 0.1.1-1.fc8 dbus-glib >= 0.61 dbus-x11 >= 0.61 gnome-icon-theme gtk2 >= 2.10.0 libORBit-2.so.0 libatk-1.0.so.0 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libcairo.so.2 libdbus-1.so.3 libdbus-glib-1.so.2 libdl.so.2 libgconf-2.so.4 libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libglade-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0 libgobject-2.0.so.0 libgthread-2.0.so.0 libgtk-x11-2.0.so.0 libnotify >= 0.4.3 libnotify.so.1 libpackagekit.so.2 libpango-1.0.so.0 libpangocairo-1.0.so.0 libpthread.so.0 librt.so.1 libxml2.so.2 rtld(GNU_HASH) + GUI app. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review