Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Business-ISBN-Data - The data pack for Business::ISBN https://bugzilla.redhat.com/show_bug.cgi?id=351751 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-10-25 23:34 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url fc752d33c352879d9462f86b358416fc Business-ISBN-Data-1.15.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs /usr/bin/perl "-MTest::Manifest" "-e" "run_t_manifest(0, 'blib/lib', 'blib/arch', )" Level is Test::Manifest::test_harness found [t/load.t t/pod.t t/pod_coverage.t t/prereq.t t/check_data_structure.t] t/load....................ok t/pod.....................ok t/pod_coverage............ok t/prereq..................ok t/check_data_structure....ok All tests successful. Files=5, Tests=300, 4 wallclock secs ( 3.87 cusr + 0.13 csys = 4.00 CPU) + Package perl-Business-ISBN-Data-1.15-2.fc8 -> Provides: perl(Business::ISBN) perl(Business::ISBN::Data) = 1.15 Requires: perl(:MODULE_COMPAT_5.8.8) perl(strict) perl(vars) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review