Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: perl-XML-Parser https://bugzilla.redhat.com/show_bug.cgi?id=226289 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-10-25 23:34 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 84d9e0001fe01c14867256c3fe115899 XML-Parser-2.34.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/astress.........ok t/cdata...........ok t/decl............ok t/defaulted.......okt/encoding........"my" variable $p masks earlier declaration in same scope at t/encoding.t line 94. ok t/external_ent....ok t/file............okt/finish..........ok t/namespaces......ok t/parament........ok t/partial.........ok t/skip............ok t/stream..........ok t/styles..........ok All tests successful. Files=14, Tests=130, 1 wallclock secs ( 0.71 cusr + 0.18 csys = 0.89 CPU) + Package perl-XML-Parser-2.34-10.fc8 -> Provides: Expat.so perl(XML::Parser) = 2.34 perl(XML::Parser::ContentModel) perl(XML::Parser::Encinfo) perl(XML::Parser::Expat) = 2.34 perl(XML::Parser::ExpatNB) perl(XML::Parser::Style::Debug) perl(XML::Parser::Style::Objects) perl(XML::Parser::Style::Stream) perl(XML::Parser::Style::Subs) perl(XML::Parser::Style::Tree) Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4) libexpat.so.1 perl >= 0:5.004 perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(DynaLoader) perl(LWP) perl(URI) perl(overload) perl(strict) perl(vars) rtld(GNU_HASH) APPROVED. You can CLOSE this review as reviewed package is already built in rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review