https://bugzilla.redhat.com/show_bug.cgi?id=1853087 --- Comment #2 from John Baublitz <jbaublitz@xxxxxxxxxx> --- Hi Robert-André, thanks for looking into this. I'm not entirely clear on all of the feedback here. I checked and see that the LICENSE and README.md files are missing from the crate so that I can take care of upstream for sure. With regards to the comment "devel should depend on libs + use pkgconfig in the auto-BR part" can you clarify a little bit? Do you mean add this line: echo 'pkgconfig(libcryptsetup)' and remove this line: BuildRequires: cryptsetup-devel Will pkgconfig pull in the dependency on cryptsetup-devel? That's needed for the header file from which bindgen generates the bindings. With regards to the comment "Package devel should also Requires pkgconfig(libcryptsetup) (When the package is installed, it is to be used in building a project thus requiring the libraries)", is this necessary so that applications that use the library pull in the proper runtime dependencies? Will this propagate to applications that pull in this library as a crate dependency? Thanks for your help! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
