https://bugzilla.redhat.com/show_bug.cgi?id=1853087 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #1 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- - Package must include LICENSE and should include README.md %files devel %license LICENSE %doc README.md %{cargo_registry}/%{crate}-%{version_no_tilde}/ If not provided by the crate, please ask upstream to include the LICENSE within their crate. - devel should depend on libs + use pkgconfig in the auto-BR part: BuildRequires: cryptsetup-libs BuildRequires: cryptsetup-devel → %generate_buildrequires %cargo_generate_buildrequires echo 'pkgconfig(libcryptsetup)' - Package devel should also Requires pkgconfig(libcryptsetup) (When the package is installed, it is to be used in building a project thus requiring the libraries). %package devel Summary: %{summary} BuildArch: noarch Requires: pkgconfig(libcryptsetup) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
