https://bugzilla.redhat.com/show_bug.cgi?id=1826439 --- Comment #27 from igor.ivanov.va@xxxxxxxxx --- (In reply to Michal Schmidt from comment #23) > (In reply to igor.ivanov.va from comment #22) > > > > > [Service] > > > > Type=forking > > > > Restart=on-failure > > > > ExecStart=/usr/sbin/vma start > > > > ExecStop=/usr/sbin/vma stop > > > > > > /usr/sbin/vma is a SysV initscript. That's terrible. > > > Why not start the deamon binary directly?: > > > ExecStart=/usr/sbin/vmad > > > (And maybe set KillSignal if needed.) > > > > It does support of some systems easier for us. > > Please elaborate. What systems? How exactly does running a SysV script from > a systemd service help? > I see the SysV script performs work that systemd already does by itself > (checking whether the service is already running, finding a process to kill, > reporting status). And it does it less accurately than systemd (which tracks > services by cgroups). It also adds some "sleep 1", which is either > pointless, or papering over a race condition bug. > > I tried running the daemon directly using "ExecStart=/usr/sbin/vmad" it the > unit file. To my surprise the daemon exits immediately when run this way. > This is because of this code in tools/daemon/daemon.c:main(): > > /* already a daemon */ > if (getppid() == 1) { > return 0; > } > > That should be removed. Daemons should not change behaviour depending on > which process spawned them. > It seems that I did not understand you initial question but I see your point now. I will look and back with answer. > > > > RestartForceExitStatus=1 SIGTERM > > > > > > It's unusual to need to use this setting. There may be a good reason for it, > > > but please double check. > > > > SIGTERM is generated by kill utility by default. So it is used to restart > > vmad in this case too. > > Yes, kill sends SIGTERM by default. I don't understand how the second > sentence follows. If I kill a service with SIGTERM, presumably I want it to > terminate, don't I? You are correct. Current behaviour was done basing on customer's requests that want to stop daemon just using systemctl and avoid stopping one by tool like kill, pkill. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
