https://bugzilla.redhat.com/show_bug.cgi?id=1845297 --- Comment #2 from Eugene A. Pivnev <ti.eugene@xxxxxxxxx> --- (In reply to dan.cermak from comment #1) > Just glanced over the spec: > - AUTHORS.md CONTRIBUTING.md INSTALL.md NEWS.md are imho not worth being > added to the final rpm as %doc, skip them Fixed. > - use %make_build instead of %{__make} %{?_smp_mflags} (double underscore > macros are considered rpm internal and should be avoided) Fixed. > - why is there a hash before `--with-lx --with-pmenu --with-gtktheme > --with-xfce4-panel-applet`? It is reminder "Don't forget default flags in next release" Moved to separate comment upper. > - upstream has tests, can you add them to %check? Failed for aarch64: https://koji.fedoraproject.org/koji/taskinfo?taskID=46246932 Upstream issue created: https://github.com/johanmalm/jgmenu/issues/123 Now 'make test' added, but commented out. Reminder. > I'll try to take a closer look in the next few days. If I forget, please > ping me. Ok. > Also, as this is a package intended for i3, would you be interested > in joining forces in the i3 SIG (https://fedoraproject.org/wiki/SIGs/i3)? I'm "Qt-only" fan (and pure openbox in "turbo mode"). So, thank you, but there is no time. ==== SPEC: https://tieugene.fedorapeople.org/rpms/jgmenu/jgmenu.spec SRPM: https://tieugene.fedorapeople.org/rpms/jgmenu/jgmenu-4.2.1-2.fc32.src.rpm Koji build (f32): https://koji.fedoraproject.org/koji/taskinfo?taskID=46247107 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
