https://bugzilla.redhat.com/show_bug.cgi?id=1845297 dan.cermak@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dan.cermak@cgc-instruments. | |com Doc Type|--- |If docs needed, set a value --- Comment #1 from dan.cermak@xxxxxxxxxxxxxxxxxxx --- Just glanced over the spec: - AUTHORS.md CONTRIBUTING.md INSTALL.md NEWS.md are imho not worth being added to the final rpm as %doc, skip them - use %make_build instead of %{__make} %{?_smp_mflags} (double underscore macros are considered rpm internal and should be avoided) - why is there a hash before `--with-lx --with-pmenu --with-gtktheme --with-xfce4-panel-applet`? - upstream has tests, can you add them to %check? I'll try to take a closer look in the next few days. If I forget, please ping me. Also, as this is a package intended for i3, would you be interested in joining forces in the i3 SIG (https://fedoraproject.org/wiki/SIGs/i3)? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
