[Bug 1847117] Review Request: python-sphinxcontrib-zopeext - Sphinx extension for documenting Zope interfaces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1847117

Andrew Bauer <zonexpertconsulting@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #4 from Andrew Bauer <zonexpertconsulting@xxxxxxxxxxx> ---
I made another pass at this while my morning coffee soaked in. Still looks
good.

Package Approved.

One non-critical thing I would point out is the example file:
/usr/lib/python3.9/site-packages/sphinxcontrib/zopeext/example.py

During my own package reviews, I have been asked to move example scripts into
docs. I've not seen any Fedora documentation that says you have to do this, but
I generally agree it's a good idea. 

I'm sure you know this an cause rpmlint to complain of scripts in the docs
folder, so there may be additional modifications to go along with this. In any
case, this is totally optional.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux