https://bugzilla.redhat.com/show_bug.cgi?id=1847117 --- Comment #3 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Andrew Bauer from comment #1) > - Python packages must not contain %{pythonX_site(lib|arch)}/* in %files > Note: Package contains %{pythonX_site(lib|arch)}/* in %files > See: https://pagure.io/packaging-committee/issue/782 Oops, that was an oversight. I meant to update that before submitting for review and forgot. It's a good thing fedora-review is on its toes. :-) Fixed. > - Package must not depend on deprecated() packages. > Note: python3-pytest4 is deprecated, you must not depend on it. > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/deprecating-packages/ It turns out that this is due to the python3-pytest-runner BR. It also turns out that this package contains no useful tests, so I have dropped all of the test-related BRs and munged setup.py slightly to be able to build without them present. If upstream adds actual tests, I will add back in the necessary BRs at that time. (In reply to Andrew Bauer from comment #2) > python3-pytest4 is deprecated, but that build requirement is autogenerated > from the py3_dist macro. > It seems safe to ignore this. One would expect py3_dist to choose > python3-pytest5 automatically, once pytest4 goes away. > > Some background reading I came across: > > https://www.spinics.net/lists/fedora-devel/msg272130.html (python3-pytest5 > is the replacement) > https://bugzilla.redhat.com/show_bug.cgi?id=1839477 (same error, but > reviewer didn't flag it) That reviewer was wrong. The whole point of deprecating packages is to ensure that no new dependencies on them can be created. You were right to flag this; I must remove the dependency (and have). New URLs: Spec URL: https://jjames.fedorapeople.org/python-sphinxcontrib-zopeext/python-sphinxcontrib-zopeext.spec SRPM URL: https://jjames.fedorapeople.org/python-sphinxcontrib-zopeext/python-sphinxcontrib-zopeext-0.2.4-2.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
