https://bugzilla.redhat.com/show_bug.cgi?id=1846175 --- Comment #6 from yanqiyu01@xxxxxxxxx --- Thank you for your review! (In reply to dan.cermak from comment #5) > This is mostly ok, a few things should be addressed though: > > - Upstream's license is not a vanilla GPLv3+, you should check with legal > how to proceed in this case. Upstream license is https://github.com/trojan-gfw/trojan/blob/master/LICENSE, isn't that a GPLv3+, I can see some file without a license, which are mostly documents and test cases. Really I don't know the difference. After all, how do I contact legal team? > - your BuildRequires are lacking version numbers (e.g. BuildRequires: > boost-devel >= 1.66) > - use %autosetup -p1 instead of %setup and %patch > - use %make_build and %make_install instead of make %{?_smp_mflags} > - don't glob the files in %_bindir and %_unitdir, as this is just 1 file > each, simply write: %{_bindir}/%{name} I will fix those then. > - your package should own %{_sysconfdir}/trojan via: %dir > %{_sysconfdir}/trojan This has been fixed in the latest source. Which you can see in the modified comment 0 > - add the note in the patch (why it exists) to the spec file This patch was removed, instead I modified the shipped configuration files, I will comment this in spec file. > - upstream provides gpg signatures, please use %gpgverify to check the > sources for consistency as described here: > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_source_file_verification I will fix this. > - upstream has a test suite, but it is not run in %check, is that > intentional? Yes, those tests won't run in a mock build environment. Maybe something related to network, in this test, it will open an instance to listen on certain port and another will try to connect. But this fails inside the container. Those will pass when build with rpmbuild without mock (same srpm file) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
