https://bugzilla.redhat.com/show_bug.cgi?id=1846175 dan.cermak@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dan.cermak@cgc-instruments. | |com --- Comment #5 from dan.cermak@xxxxxxxxxxxxxxxxxxx --- This is mostly ok, a few things should be addressed though: - Upstream's license is not a vanilla GPLv3+, you should check with legal how to proceed in this case. - your BuildRequires are lacking version numbers (e.g. BuildRequires: boost-devel >= 1.66) - use %autosetup -p1 instead of %setup and %patch - use %make_build and %make_install instead of make %{?_smp_mflags} - don't glob the files in %_bindir and %_unitdir, as this is just 1 file each, simply write: %{_bindir}/%{name} - your package should own %{_sysconfdir}/trojan via: %dir %{_sysconfdir}/trojan - add the note in the patch (why it exists) to the spec file - upstream provides gpg signatures, please use %gpgverify to check the sources for consistency as described here: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_source_file_verification - upstream has a test suite, but it is not run in %check, is that intentional? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
