https://bugzilla.redhat.com/show_bug.cgi?id=1833469 --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to dan.cermak from comment #1) > Sorry for taking so long to review this Jerry. I've found the following > minor issues: > - CONTRIBUTING.md is imho not necessary to include as %doc Agreed. I have dropped it. > - upstream's opam file notes the following dependency on ocaml-base: {>= > "v0.13" & < "v0.14"} but the spec has only >= 0.13. If that is intended, > maybe add a comment explaining that? I didn't realize it was possible to express both constraints. I've added a boolean expression that does the job. > - since it took me so long to review this, upstream released 0.14 in the > meantime They did. I need to update all of the Jane Street packages from 0.13 to 0.14, but haven't had time to work through the mock builds yet. With the datacenter move looming, I probably won't get around to it for a couple of weeks or so. Can we finish the review with the 0.13 version, then I can update the whole Jane Street ecosystem to 0.14 later? > Otherwise this looks perfectly fine to me! Thanks for the review, Dan. No worries on the delay. $DAYJOB has been keeping me pretty busy lately anyway. New URLs: Spec URL: https://jjames.fedorapeople.org/ocaml-fieldslib/ocaml-fieldslib.spec SRPM URL: https://jjames.fedorapeople.org/ocaml-fieldslib/ocaml-fieldslib-0.13.0-1.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
