https://bugzilla.redhat.com/show_bug.cgi?id=1833469 --- Comment #1 from dan.cermak@xxxxxxxxxxxxxxxxxxx --- Sorry for taking so long to review this Jerry. I've found the following minor issues: - CONTRIBUTING.md is imho not necessary to include as %doc - upstream's opam file notes the following dependency on ocaml-base: {>= "v0.13" & < "v0.14"} but the spec has only >= 0.13. If that is intended, maybe add a comment explaining that? - since it took me so long to review this, upstream released 0.14 in the meantime Otherwise this looks perfectly fine to me! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
