https://bugzilla.redhat.com/show_bug.cgi?id=1832562 Michael Schwendt <bugs.michael@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugs.michael@xxxxxxx --- Comment #6 from Michael Schwendt <bugs.michael@xxxxxxx> --- This review request is a bit of a mystery. The spec file contains a few grave mistakes that have been introduced since the older version found at: https://pagure.io/tpcclib/blob/master/f/tpcclib.spec > %package devel > Summary: Libraries files for tpcclib development > # Upstream only provides static libraries > Provides: %{name}-static%{?_isa} = %{version}-static Carefully follow https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_static_libraries since right now you would be unable to "BuildRequires: tpcclib-static" as per https://docs.fedoraproject.org/en-US/packaging-guidelines/#_statically_linking_executables Also notice these two: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#subpackage-licensing > %files devel > %{_includedir}/*.a > %{_includedir}/*.h Static libraries belong into %{_libdir} Currently, there are 34 static libraries and 34 header files. Can you tell a bit more about the usage scenario of this package? What external software does (or will) use these libs? Each of the header files includes a missing "tpcclibConfig.h" which indicates that these likely are internal headers and libs and not a public API. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
