[Bug 1829340] Review Request: python3-Pebble - Threading and multiprocessing eye-candy for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1829340



--- Comment #4 from Martin Liška <mliska@xxxxxxx> ---
(In reply to Miro Hrončok from comment #3)
> Ok, spec sanity:

Thank you for the review:

> 
> 1) the name should be lowercase
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/
> #_general_naming

Fixed.

> 
> 2) is the copyright header required by your employer? Fedora contributors
> are covered by
> https://fedoraproject.org/wiki/Legal:Fedora_Project_Contributor_Agreement
> which makes this MIT by default

Removed.

> 
> 3) the source can be %{pypi_source Pebble}

Done.

> 
> 4) there should be a python3-pebble subpackage, see
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_naming

How are these 2 files related?

> 
> 5) the license tag in Fedora is unfortunately different from SUSE, see
> https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses
> 

Done.

> 6) The Group tag is not supposed to be used:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

Removed.

> 
> 7) %{python3_sitelib}/* is not supposed to be used:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
> #_files_to_include

Hm, I noticed it's being used by other Fedora packages:
https://apps.fedoraproject.org/packages/python3-GitPython/sources/spec/

> 
> 8) changelog is missing (maybe intentionally for the review? or because it's
> external in Open Build Service?)

Added.

Please pull:
https://github.com/marxin/fedora-Pebble/commit/dc84efb94ed0532256c440a33b138e5c518d0769


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux