https://bugzilla.redhat.com/show_bug.cgi?id=1829340 --- Comment #3 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Ok, spec sanity: 1) the name should be lowercase https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_general_naming 2) is the copyright header required by your employer? Fedora contributors are covered by https://fedoraproject.org/wiki/Legal:Fedora_Project_Contributor_Agreement which makes this MIT by default 3) the source can be %{pypi_source Pebble} 4) there should be a python3-pebble subpackage, see https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_naming 5) the license tag in Fedora is unfortunately different from SUSE, see https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses 6) The Group tag is not supposed to be used: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections 7) %{python3_sitelib}/* is not supposed to be used: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_files_to_include 8) changelog is missing (maybe intentionally for the review? or because it's external in Open Build Service?) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
