[Bug 1831981] Review Request: xdg-desktop-portal-wlr - xdg-desktop-portal backend for wlroots

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1831981



--- Comment #2 from Aleksei Bavshin <alebastr89@xxxxxxxxx> ---
(In reply to Till Hofmann from comment #1)
> >    BuildRequires:  pkgconfig(libpipewire-0.3) >= 0.3.4
> This would avoid the explicit (and redundant) dependency on pipewire.

BR does not directly affect binary package Requires, thus the explicit
versioned dependency on pipewire is still necessary. I can change both
dependencies to 0.3.4; it'll be easier to track and 0.3.4 is just 1 karma point
from stable f32-updates.

% rpm -qRp
results_xdg-desktop-portal-wlr/0.1.0/0.1.fc32/xdg-desktop-portal-wlr-0.1.0-0.1.fc32.x86_64.rpm
|grep pipewire
libpipewire-0.3.so.0()(64bit)

> * The versioning constraint in
> >    pkgconfig(wayland-protocols) >= 1.14
> is unnecessary. Even Fedora 30 ships 1.17. In this case, it is recommended to remove the constraint [1]:

Nice catch. Removed.

Spec URL:
https://download.copr.fedorainfracloud.org/results/alebastr/sway-extras/fedora-rawhide-x86_64/01368748-xdg-desktop-portal-wlr/xdg-desktop-portal-wlr.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/alebastr/sway-extras/fedora-rawhide-x86_64/01368748-xdg-desktop-portal-wlr/xdg-desktop-portal-wlr-0.1.0-0.1.fc33.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux