https://bugzilla.redhat.com/show_bug.cgi?id=1831981 --- Comment #1 from Till Hofmann <thofmann@xxxxxxxxxxxxxxxxx> --- Some remarks: * Why not just > BuildRequires: pkgconfig(libpipewire-0.3) >= 0.3.4 This would avoid the explicit (and redundant) dependency on pipewire. * The versioning constraint in > pkgconfig(wayland-protocols) >= 1.14 is unnecessary. Even Fedora 30 ships 1.17. In this case, it is recommended to remove the constraint [1]: > For instance in the example above, when no current Fedora release shipped with libfubar < 1.2.3-7, it is no longer necessary to list the explicit, versioned requirement. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_requires -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx