https://bugzilla.redhat.com/show_bug.cgi?id=1814682 Honggang LI <honli@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #54 from Honggang LI <honli@xxxxxxxxxx> --- I had run basic functional tests for rshim. Confirmed it works as expected and the output of fedora-review tool looks good for me. Set the 'fedora-review+' flag. Michal, please add lsun into packager group. ===================================================================================== Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. PASS [ ]: Package contains no static executables. PASS [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. PASS [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GPL (v2)", "Unknown or generated", "GPL (v2)". 23 files have unknown license. Detailed output of licensecheck in /home/honli/review/1814682-rshim/licensecheck.txt PASS. It is a review tool issue, as those files have "SPDX-License-Identifier: GPL-2.0-only" tag. [ ]: License file installed when any subpackage combination is installed. PASS. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/systemd, /usr/lib/systemd/system PASS [ ]: %build honors applicable compiler flags or justifies otherwise. PASS [ ]: Package contains no bundled libraries without FPC exception. PASS [ ]: Changelog in prescribed format. PASS [ ]: Sources contain only permissible code or content. PASS [ ]: Package contains desktop file if it is a GUI application. PASS. It is not a GUI application. [ ]: Development files must be in a -devel package PASS. no devel [ ]: Package uses nothing in %doc for runtime. PASS [ ]: Package consistently uses macros (instead of hard-coded directory names). PASS [ ]: Package is named according to the Package Naming Guidelines. PASS [ ]: Package does not generate any conflict. PASS [ ]: Package obeys FHS, except libexecdir and /usr/target. PASS [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. PASS [ ]: Requires correct, justified where necessary. PASS [ ]: Spec file is legible and written in American English. PASS [ ]: Package contains systemd file(s) if in need. PASS. start/stop rshim service confirmed the systemd service file works. [ ]: Useful -debuginfo package or justification otherwise. PASS [ ]: Package is not known to require an ExcludeArch tag. PASS [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. PASS [ ]: Package complies to the Packaging Guidelines PASS [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in rshim [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. PASS [ ]: Final provides and requires are sane (see attachments). PASS [ ]: Package functions as described. PASS. I had run functional tests. It works. [ ]: Latest version is packaged. PASS [ ]: Package does not include license text files separate from upstream. PASS [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. PASS. Upstream does not use gpgverify for rshim. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. PASS [ ]: Package should compile and build into binary rpms on all supported architectures. PASS [ ]: %check is present and all tests pass. PASS, no %check [ ]: Packages should try to preserve timestamps of original installed files. PASS [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rshim-2.0.4-1.fc33.x86_64.rpm rshim-debuginfo-2.0.4-1.fc33.x86_64.rpm rshim-debugsource-2.0.4-1.fc33.x86_64.rpm rshim-2.0.4-1.fc33.src.rpm 4 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (debuginfo) ------------------- Checking: rshim-debuginfo-2.0.4-1.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- rshim-debuginfo.x86_64: W: invalid-url URL: https://github.com/mellanox/rshim-user-space <urlopen error [Errno -2] Name or service not known> rshim.x86_64: W: invalid-url URL: https://github.com/mellanox/rshim-user-space <urlopen error [Errno -2] Name or service not known> rshim-debugsource.x86_64: W: invalid-url URL: https://github.com/mellanox/rshim-user-space <urlopen error [Errno -2] Name or service not known> 3 packages and 0 specfiles checked; 0 errors, 3 warnings. PASS. It is a fedora-review tool issue. Those URLs are valid. Source checksums ---------------- https://github.com/Mellanox/rshim-user-space/releases/download/rshim-2.0.4/rshim-2.0.4.tar.gz : CHECKSUM(SHA256) this package : 48d0e0467a3d13286c810d2c50751bfbb58cd8e328b82ebe8e08264add47b052 CHECKSUM(SHA256) upstream package : 48d0e0467a3d13286c810d2c50751bfbb58cd8e328b82ebe8e08264add47b052 Requires -------- rshim (rpmlib, GLIBC filtered): /bin/sh kmod(cuse.ko) libc.so.6()(64bit) libfuse.so.2()(64bit) libfuse.so.2(FUSE_2.4)(64bit) libfuse.so.2(FUSE_2.5)(64bit) libfuse.so.2(FUSE_2.8)(64bit) libpci.so.3()(64bit) libpci.so.3(LIBPCI_3.0)(64bit) libpci.so.3(LIBPCI_3.5)(64bit) libpthread.so.0()(64bit) libusb-1.0.so.0()(64bit) rtld(GNU_HASH) rshim-debuginfo (rpmlib, GLIBC filtered): rshim-debugsource (rpmlib, GLIBC filtered): Provides -------- rshim: rshim rshim(x86-64) rshim-debuginfo: debuginfo(build-id) rshim-debuginfo rshim-debuginfo(x86-64) rshim-debugsource: rshim-debugsource rshim-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1814682 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Perl, SugarActivity, R, PHP, Ocaml, Python, Haskell, Java, fonts, Ruby Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
