https://bugzilla.redhat.com/show_bug.cgi?id=1814682 --- Comment #53 from Honggang LI <honli@xxxxxxxxxx> --- (In reply to lsun from comment #49) > > Why does the rshim.service use killall in the first place? There is: > > > KillMode=process > > > > Why this mode? Do you need child processes to be left running in the cgroup > > after the service is stopped? > > If yes, commenting on it in the unit file would be nice. > > It's a copy/paste error. I would like to stop all processes when service > stops. > > > > > > ExecStop=/usr/bin/killall -SIGKILL rshim > > > > Referencing processes to kill by name is not good. It would kill unrelated > > processes with the same name. > > Is none of systemd's kill modes suitable for stopping the service without > > additional help? > > And why SIGKILL? Does it not stop on SIGTERM? > > Will update in next posted version with the following: > - Remove the "Requires: psmisc" > - Remove "ExecStop". > - Use "KillMode=control-group" > - Support SIGTERM > > [Service] > Restart=always > Type=forking > ExecStart=-/usr/sbin/rshim $OPTIONS > KillMode=control-group Confirmed rshim.service start/stop works with the new systemd service file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
