https://bugzilla.redhat.com/show_bug.cgi?id=1822971 --- Comment #35 from Nick Black <dank@xxxxxxxxx> --- I've rebuilt with a new spec file. * Verified that notcurses.py is installed 0755 (achieved via %attr directive) * Verified that /usr/share/notcurses gets cleaned up on removal (indeed, find /usr -iname \*notcurses\* is empty upon removal) * Verified that the -data package is gone, and the binaries/man pages are in -utils. The base package installs only shared libraries. * Blank line between specfile changelog entries. I think this answers everything you raised in this most recent round of review. In particular, /usr/share/notcurses is properly owned (and thus removed). As I noted above, the exit() is in the child path of a fork(), following a failed exec(). I believe this to be acceptable library behavior. Please note that all child processes are managed with Linux 5 pidfds, eliminating some typical worries there. I've uploaded the new SRPM and RPMs: https://www.dsscaw.com/repos/dnf/ [vps](0) $ sha256sum * 12a220effbbb6674880ad5da448a167905ab22611ea3569d6eaf97ed46121891 build.log 3b361c0d38f2fd17ab6b0a220d35557c1c27581e86ac216f6c6680a538ff4125 hw_info.log b6671f523a9f27223e777be3a23c8850bae755709e1ed75fa732419c2b81a35b installed_pkgs.log e73cbfefa06fb4288f7f0e160417108bce953009b11929d4a5c23696e162ba9c notcurses-1.3.3-1.fc33.src.rpm 677adf06441b7be9ef0ebe2795a3ac67332e11a360b5999f38c385e10361b351 notcurses-1.3.3-1.fc33.x86_64.rpm 58b7cfb64a1e0000738b966bda7d4adb6fc84cb113d81a386954e42b797e6439 notcurses-debuginfo-1.3.3-1.fc33.x86_64.rpm 579e4c10d69808455332cf7cf1422a187466ed59f73013640282781458d9137f notcurses-debugsource-1.3.3-1.fc33.x86_64.rpm 666d9ec54d33e8accea13325cd71d033e0b96a859a3e83b47e610692c1bd59d8 notcurses-devel-1.3.3-1.fc33.x86_64.rpm a51497a0596ba57a0281824266408df7cecf517cf9031b19c1262e4aaea094f4 notcurses-static-1.3.3-1.fc33.x86_64.rpm 10e57a4dcb1f88af632e7c540647c5fcf2a26a96e3bfbbbfb53048fed05a972c notcurses-utils-1.3.3-1.fc33.x86_64.rpm 9bd852283ef92bbaa3702d45dcbf7cedba2cc4e274f75dca392cf18faefee235 notcurses-utils-debuginfo-1.3.3-1.fc33.x86_64.rpm d4612c2fe0dd9ffa7decbbe763e03f1cdee30d68e5bc47af7eb7b9bd5d3cfb24 python3-notcurses-1.3.3-1.fc33.x86_64.rpm 9e855b0455e899b70df7ed59591e97d9f5c64e0d6b560c0eee2a70e72113decf python3-notcurses-debuginfo-1.3.3-1.fc33.x86_64.rpm 54949abce9bf6343969eac5a9169a79fc6dc2194441fe2ddeecbe96c4b22b22e root.log 46ff4b0254c09f75d9fa68710ff30035e559a596bf459b4c88b3a00b368a337f state.log [vps](0) $ Specfile: https://raw.githubusercontent.com/dankamongmen/notcurses/master/tools/notcurses.spec PTAL. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
