https://bugzilla.redhat.com/show_bug.cgi?id=1822971 Nick Black <dank@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(dank@xxxxxxxxx) | --- Comment #34 from Nick Black <dank@xxxxxxxxx> --- (1) You are correct in all analysis of the dependencies and deployment of the -data package--it would just be part of the main package. The only reason why I made it distinct was due to wanting to avoid replication across multiple architecture-dependent binary packages. I.e. if the package is provided for 5 architectures, without this no-arch package, you're replicating the same 5MB video across all five architectures, consuming 25MB on FTP servers etc. If this is not a big concern for Fedora (it's a cause for global apocalypse in Debian thinking), it can happily be subsumed into an existing binary-specific package. So I think what I'll do is *almost* what you allude to, and *almost* what I mentioned earlier: - split out the binaries from the shared libraries, into notcurses-utils - fold notcurses-data into notcurses-utils This way, there's no extra package, people who are only installing notcurses as a dependency for some other program needn't install stuff they don't need, and everything is still shipped. Sound good? (2) Done. (3) exit(2) is called only in the following structure: ret->pid = launch_pipe_process(&fd, &ret->pidfd); if(ret->pid == 0){ execv(bin, arg); fprintf(stderr, "Error execv()ing %s\n", bin); exit(EXIT_FAILURE); }else if(ret->pid < 0){ free(ret); return NULL; } so I think that's safe. (4) Got it, will test the installed rpm for the proper perms this time, how embarrassing. Thankfully, all issues you've raised can be fixed with specfile changes, and thus do not require a new upstream release. I ought have all issues fixed by EoD. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
