https://bugzilla.redhat.com/show_bug.cgi?id=1826034 --- Comment #5 from Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> --- Looks mostly OK, I can approve once the license issue is clarified (see the review below). Attaching the licensecheck.txt that fedora-review produces. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== Issues ===== [!]: License field in the package spec file matches the actual license. Ignore Expat - the license checker somehow misidentifies the MIT-licensed files in sanitizers-cmake. *but* - The Android files should probably be removed, or you need to add ASL 2.0 to the list of licenses - Some files are actually BSD-licensed (add BSD to the list of licenses) - The files with unknown license presumably fall under the project's ISC license Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "ISC License", "Expat License", "Apache License 2.0", "BSD 3-clause "New" or "Revised" License". 73 files have unknown license. Detailed output of licensecheck in /home/michel/src/fedora/reviews/1826034-cubeb/licensecheck.txt [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Might be worth asking upstream to also declare some files are ASL 2.0 and BSD licensed and include those license files in their repo [!]: %check is present and all tests pass. Not a review blocker, but from looking at .gitmodules googletest is needed to run tests -- might be nice to include it and enable tests once this package is in Fedora ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "ISC License", "Expat License", "Apache License 2.0", "BSD 3-clause "New" or "Revised" License". 73 files have unknown license. Detailed output of licensecheck in /home/michel/src/fedora/reviews/1826034-cubeb/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. A bit surprised RPM automatically picks up a dependency on cmake-filesystem for -devel for directory ownership, nice. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [?]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: cubeb-0.2-1.20200409.git9caa5b1.fc33.x86_64.rpm cubeb-devel-0.2-1.20200409.git9caa5b1.fc33.x86_64.rpm cubeb-debuginfo-0.2-1.20200409.git9caa5b1.fc33.x86_64.rpm cubeb-debugsource-0.2-1.20200409.git9caa5b1.fc33.x86_64.rpm cubeb-0.2-1.20200409.git9caa5b1.fc33.src.rpm cubeb-devel.x86_64: W: no-documentation cubeb-devel.x86_64: W: no-manual-page-for-binary cubeb-test 5 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (debuginfo) ------------------- Checking: cubeb-debuginfo-0.2-1.20200409.git9caa5b1.fc33.x86_64.rpm cubeb-devel-debuginfo-0.2-1.20200409.git9caa5b1.fc33.x86_64.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- cubeb-debuginfo.x86_64: W: invalid-url URL: https://github.com/kinetiknz/cubeb <urlopen error [Errno -2] Name or service not known> cubeb.x86_64: W: invalid-url URL: https://github.com/kinetiknz/cubeb <urlopen error [Errno -2] Name or service not known> cubeb-devel.x86_64: W: invalid-url URL: https://github.com/kinetiknz/cubeb <urlopen error [Errno -2] Name or service not known> cubeb-devel.x86_64: W: no-documentation cubeb-devel.x86_64: W: no-manual-page-for-binary cubeb-test cubeb-debugsource.x86_64: W: invalid-url URL: https://github.com/kinetiknz/cubeb <urlopen error [Errno -2] Name or service not known> cubeb-devel-debuginfo.x86_64: W: invalid-url URL: https://github.com/kinetiknz/cubeb <urlopen error [Errno -2] Name or service not known> 5 packages and 0 specfiles checked; 0 errors, 7 warnings. Source checksums ---------------- https://github.com/arsenm/sanitizers-cmake/archive/aab6948fa863bc1cbe5d0850bc46b9ef02ed4c1a/sanitizers-cmake-aab6948.tar.gz : CHECKSUM(SHA256) this package : 9f5b073625375322236a94ce8d2d803cdedad321c91e63845f487b9ebfb2c433 CHECKSUM(SHA256) upstream package : 9f5b073625375322236a94ce8d2d803cdedad321c91e63845f487b9ebfb2c433 https://github.com/kinetiknz/cubeb/archive/9caa5b113a2a4faef8bd31894fc2d762b884a5cf/cubeb-9caa5b1.tar.gz : CHECKSUM(SHA256) this package : 6c440aa0aa454a747bd5b8adb11be891911399ab1b4a6d64d83bcd3bcd73b17f CHECKSUM(SHA256) upstream package : 6c440aa0aa454a747bd5b8adb11be891911399ab1b4a6d64d83bcd3bcd73b17f Requires -------- cubeb (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) rtld(GNU_HASH) cubeb-devel (rpmlib, GLIBC filtered): cmake-filesystem(x86-64) cubeb(x86-64) libc.so.6()(64bit) libcubeb.so.0()(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) rtld(GNU_HASH) cubeb-debuginfo (rpmlib, GLIBC filtered): cubeb-debugsource (rpmlib, GLIBC filtered): Provides -------- cubeb: cubeb cubeb(x86-64) libcubeb.so.0()(64bit) cubeb-devel: cmake(cubeb) cubeb-devel cubeb-devel(x86-64) cubeb-debuginfo: cubeb-debuginfo cubeb-debuginfo(x86-64) debuginfo(build-id) cubeb-debugsource: cubeb-debugsource cubeb-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1826034 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Java, PHP, fonts, Haskell, SugarActivity, R, Ocaml, Perl, Python Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
