https://bugzilla.redhat.com/show_bug.cgi?id=1818670 Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dominik@xxxxxxxxxxxxxx --- Comment #5 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- %define debug_package %{nil} is no-go, a proper debug{info,source} packages must be generated. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Debuginfo/ . Fedora has Golang specific guidelines at https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/ . Is there any reason why you're not following them? The empty %check section is useless. Please either run some after-build tests there or drop it. Golang guidelines mention a %gochecks macro which runs built-in tests in a standard way. ExclusiveArch: x86_64 is not justified, please see: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_support As for bundling so many build dependencies, this is something that should be avoided in general: https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling . Please make an effort to unbundle them first. This may require submitting additional packages for review. I can sponsor you, but this package requires a bit more work to pass review. It would also help if you could do a couple of informal reviews of other pending packages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
