https://bugzilla.redhat.com/show_bug.cgi?id=1818670 --- Comment #4 from Devin Acosta <devin@linuxstack.cloud> --- I have spent a little over an entire week making lots of modifications per your request. I changed the following: - Removed my cleanup jobs so they don't delete users, or cleanup any directories - I fixed my installation section to all use common (install -m xxx) method. - I cleaned up a lot of the %files, %attr() section, also fixed the /var/run issue I ran into, which i talked in IRC channel about. - I had it end up creating 3 RPMS like the Sensu Enterprise edition does to keep in-line with what they are doing. - I fixed the dynamic user creation as requested. The only thing that I have yet to really tackle is the way that I am TARing up the Go Dependencies and just extracting them (since the Koji) doesn't allow for external access to download the modules it needs to compile. I am still working on seeing what options i have there to clean up the code a little bit more. please check out my latest SPEC file located at: https://raw.githubusercontent.com/devinacosta/sensugo-koji/master/rpmbuild/SPECS/sensu-go.spec Also You can see my latest build output here: https://koji.fedoraproject.org/koji/taskinfo?taskID=43104293 Let me know if you have more suggestions or if i missed anything? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
