https://bugzilla.redhat.com/show_bug.cgi?id=1823599 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@xxxxxxxxxx --- Comment #12 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- %check desktop-file-install Is not good: You should either desktop-file-validate the specfile in %check, or desktop-file-install (which also validates as a side effect) from %install. Installing files from %check is dangerous, because in certain circumstances, %check can be skipped entirely. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage -------- sed -i -e 's@lib/gjots2@lib/python%{python3_version}/site-packages/gjots2@g' setup.py Why is this actually needed? In what context does this change happen? Please, add a comment to the spec that explains this. -------- %{python3_sitelib}/%{name}-%{version}-py%{python3_version}.egg-info Consider adding leading slash to ensure this remains a directory. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
