https://bugzilla.redhat.com/show_bug.cgi?id=1823599 --- Comment #11 from Alexander Ploumistos <alex.ploumistos@xxxxxxxxx> --- Created attachment 1680099 --> https://bugzilla.redhat.com/attachment.cgi?id=1680099&action=edit gjots2 screenshot showing block glyphs Hello Bob, Kudos for the work so far and especially with the AppStream metadata. As for the id tag, it needs to conform to the reverse-DNS scheme (this is copied from the link I gave you): "The ID must follow a reverse-DNS scheme, consisting of {tld}.{vendor}.{product}, for example org.kde.Gwenview or com.hugski.ColorHug2. Ownership of {vendor}.{tld} in the domain name system guarantees uniqueness of IDs." In other words, this should be one of the strings I have proposed or something similar, if you have a better idea. As for the "Encoding=UTF-8" key in gjots2.desktop, I think it's been over a decade that it was dropped from the specification, it's safe to lose it. Other issues: 1. Licensing Unless you want to add or remove the "or later" part everywhere in your upstream code, the package's license in the spec file should be GPLv2 and not GPLv2+, because the "effective license" in this case is GPLv2. https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#What_is_.22effective_license.22_and_do_I_need_to_know_that_for_the_License:_tag.3F https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/ in your %files section, change %doc AUTHORS COPYING ChangeLog README doc/gjots2.gjots to %license COPYING %doc AUTHORS ChangeLog README doc/gjots2.gjots 2. American English spelling There are several instances of "organise", that should be "organize". Oddly, the Cambridge Dictionary doesn't have "marshall", about which rpmlint complains, whereas Webster's lists it as an alternate spelling of "marshal". What's more odd, a couple of Australian online dictionaries do not consider it as valid. 3. When I run gjots2 and select "New", I get a series of block glyphs, as though I'm missing support for a specific language (see attachment). What are these? We're almost there! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
