https://bugzilla.redhat.com/show_bug.cgi?id=1822971 David Cantrell <dcantrell@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |BuildFails Flags| |needinfo?(dank@xxxxxxxxx) --- Comment #9 from David Cantrell <dcantrell@xxxxxxxxxx> --- This package fails to build as-is. I made some changes to the spec file to get it to build: --- notcurses-1.3.0-1.fc32.src/notcurses.spec 2020-04-12 01:26:33.000000000 -0400 +++ rpmbuild/SPECS/notcurses.spec 2020-04-15 11:55:45.080414210 -0400 @@ -13,7 +13,7 @@ BuildRequires: gcc-c++ BuildRequires: pandoc BuildRequires: python3-devel -BuildRequires: python3-setuptools +BuildRequires: python3-cffi BuildRequires: pkgconfig(ncurses) %description @@ -56,12 +56,14 @@ cd build %cmake -DUSE_FFMPEG=off -DUSE_TESTS=off .. %make_build +cd python +%py3_build %install cd build %make_install cd python -python setup.py install --root=%{buildroot} --optimize=1 +%py3_install %files %doc CHANGELOG.md README.md Python packaging macros are explained in more detail here: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ Python RPM packaging in Fedora has gotten a lot easier in recent years. I am testing building locally using mock(1) like this: mock -r fedora-rawhide-x86_64 --rebuild notcurses-1.3.0-1.src.rpm Please update the spec file and SRPM so I can continue the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
