https://bugzilla.redhat.com/show_bug.cgi?id=1823265 --- Comment #9 from Aleksei Bavshin <alebastr89@xxxxxxxxx> --- RPM documentation[1] says that rich dependencies should be enclosed with parenthesis, because otherwise RPM will treat this as a 3 separate package clauses: Requires: (sway >= 1.4 if sway) I confirmed that it works as desired on Fedora 31: % sudo dnf install sway wayvnc Last metadata expiration check: 0:00:55 ago on Wed 15 Apr 2020 03:27:30 PM UTC. Error: Problem: conflicting requests - package sway-1.2-2.module_f31+6388+036e501b.x86_64 requires (sway >= 1.4 if sway), but none of the providers can be installed - package sway-1.1.1-3.fc31.x86_64 requires (sway >= 1.4 if sway), but none of the providers can be installed - package sway-1.1.1-2.fc31.x86_64 requires (sway >= 1.4 if sway), but none of the providers can be installed - package sway-1.4-3.module_f31+7694+72cbf402.x86_64 is filtered out by modular filtering (try to add '--skip-broken' to skip uninstallable packages) (In reply to Bob Hepple from comment #7) > .... just 'BSD' per > https://fedoraproject.org/wiki/Licensing:BSD?rd=Licensing/BSD#3ClauseBSD ??? Yes, just BSD. It's in the license list under 'BSD License (no advertising)'. (In reply to Bob Hepple from comment #8) > ... removing that yields -O2 instead of -O3 and upstream recommends it: > > 'Setting the buildtype flag is not required but it is recommended as there > are significant performance gains to be had from an optimised build.' I'm pretty sure that -O2 is still considered optimized build. But let's see what `--buildtype release` actually does: > %meson [26/35] cc -Iwayvnc@exe -I. -I.. -I../include -I/usr/include/pixman-1 -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu11 -D_GNU_SOURCE -DNDEBUG -O2 -g -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -MD -MQ 'wayvnc@exe/src_main.c.o' -MF 'wayvnc@exe/src_main.c.o.d' -o 'wayvnc@exe/src_main.c.o' -c ../src/main.c > %meson --buildtype release [26/35] cc -Iwayvnc@exe -I. -I.. -I../include -I/usr/include/pixman-1 -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=gnu11 -O3 -D_GNU_SOURCE -DNDEBUG -O2 -g -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -MD -MQ 'wayvnc@exe/src_main.c.o' -MF 'wayvnc@exe/src_main.c.o.d' -o 'wayvnc@exe/src_main.c.o' -c ../src/main.c In this case gcc takes the last specified -O flag which is still -O2. The working way of applying -O3 is to override %optflags macro, however guidelines[2] say that this is discouraged unless you have a good reason. A benchmark that shows significant performance improvement from -O3 could be such reason. It doesn't seem critical for wayvnc (I don't see a code that could significantly win from -O3), but it might be worth investigating for neatvnc. [1] https://rpm.org/user_doc/boolean_dependencies.html [2] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
