https://bugzilla.redhat.com/show_bug.cgi?id=1823265 --- Comment #4 from Aleksei Bavshin <alebastr89@xxxxxxxxx> --- Unnecessary BRs: pkgconfig(glib), pkgconfig(libglvnd), pkgconfig(wayland-eglstream). Build passes without all of those. > %meson --buildtype=release Please, remove --buildtype. %meson macro already sets `--buildtype plain` > %doc README.md Consider adding FAQ.md to the doc. > Requires: wlroots >= 0.10 Please, add a comment that the dependency here is added only to enforce minimal version of a wlroots-based compositor. Also, technically that makes package not installable on Fedora < 32 without sway module. It's safe to ignore f30 (EOL by the end of May) and epel8 (does not even have sway modular builds), but f31 is still supported for a while. However if we allow installation with older sway it would only serve as a source of confusion and bug reports. I admit that I don't know a good solution for that besides outright ignoring f31. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
