https://bugzilla.redhat.com/show_bug.cgi?id=1824016 Aleksei Bavshin <alebastr89@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alebastr89@xxxxxxxxx --- Comment #1 from Aleksei Bavshin <alebastr89@xxxxxxxxx> --- Some things to address before formal review: > License: ISC ISC and MIT and Unlicense (with comment about bundled miniz) Also, `Provides: bundled(miniz) = 2.1.0` with a comment that it's already removed in upstream master. > BuildRequires: cmake Not necessary, all dependencies are shipping pkgconfig files. CMake is only required when you know that there's dependency that does not have pkgconfig file but provides cmake modules. > %files > %{_libdir}/lib%{name}.so.* Please, specify at least one element of SONAME to avoid unnoticed incompatible SONAME changes[1]. I.e. %{_libdir}/lib%{name}.so.0* > %{_includedir}/* I'd prefer this to be more specific, but that's just nitpicking. > cpu = host_machine.cpu_family() > > if cpu == 'x86_64' > c_args += '-mavx' > elif cpu == 'arm' > c_args += '-mfpu=neon' > endif It's better to remove that from meson.build with downstream patch. Upstream issue[2] mentions that at least x86_64 works fine without -mavx, although it does not specify if there's any noticeable performance loss. IIRC, Fedora baseline for x86_64 is K8 (no avx support) and for ARM - hardware without neon instruction set support. I could be wrong about ARM, but it's still better to keep optimization limited to distribution-wide optflags. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files [2] https://github.com/any1/neatvnc/issues/21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
