Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-gdata - A Python module for accessing online Google services https://bugzilla.redhat.com/show_bug.cgi?id=329331 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-10-18 01:47 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM but not for RPM. python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/apps/service.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/spreadsheet/service.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/docs/__init__.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/base/service.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/atom/__init__.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/__init__.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/docs/service.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/atom/service.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/calendar/__init__.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/spreadsheet/__init__.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/service.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/test_data.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/apps/__init__.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/base/__init__.py 0644 python-gdata.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/gdata/calendar/service.py 0644 ==> But these looks false messages. Ignored. + source files match upstream. b6f6aa192446047d8045d3c30345f1ef gdata.py-1.0.8.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. APPROVED. SHOULD: Remove CFLAGS as this is python package and no compilations is happening that needs CFLAGS. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review