Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-gdata - A Python module for accessing online Google services https://bugzilla.redhat.com/show_bug.cgi?id=329331 ------- Additional Comments From bnocera@xxxxxxxxxx 2007-10-16 06:15 EST ------- (In reply to comment #1) > rpmlint gave me > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/gdata/apps/service.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/gdata/spreadsheet/service.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/gdata/docs/__init__.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/gdata/base/service.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/atom/__init__.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/gdata/__init__.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/gdata/docs/service.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/atom/service.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/gdata/calendar/__init__.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/gdata/spreadsheet/__init__.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/gdata/service.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/gdata/test_data.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/gdata/apps/__init__.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/gdata/base/__init__.py 0644 > python-gdata.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/gdata/calendar/service.py 0644 Those are completely bogus. We have #!/usr/bin/python up there, for use in the unit tests. They're not any useful for run-time. > If this is of noarch type then do we still need following in SPEC ? > %{!?python_sitearch: %define python_sitearch %(%{__python} -c "from > distutils.sysconfig import get_python_lib; print get_python_lib(1)")} Removed. (In reply to comment #2) > Good to add tests directory as %doc > Also, are files under samples are also examples? If yes you can also add them to > %doc. I think neither they are used in build nor they are installed. > > remember to run rpmlint on rpms before providing update. samples added, the tests are unit tests, that wouldn't be useful at all, unless you wanted to develop python-gdata. Updated: http://www.gnome.org/~hadess/python-gdata/python-gdata-1.0.8-2.fc8.src.rpm http://www.gnome.org/~hadess/python-gdata/python-gdata.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review