https://bugzilla.redhat.com/show_bug.cgi?id=1823117 Neal Gompa <ngompa13@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@xxxxxxxxx --- Comment #5 from Neal Gompa <ngompa13@xxxxxxxxx> --- Just dropping in with some notes for improving the spec to comply with Fedora Packaging Guidelines, as I'm interested in seeing Open Surge land in Fedora. :) > # There have been some useful changes to CMakeLists.txt since v.0.5.1.2 has been released > Source1: https://raw.githubusercontent.com/alemart/opensurge/1def8579e661e3128e495b7108a1988d40453a65/CMakeLists.txt Why not just package a snapshot release or cherry-pick patches? > Provides: bundled(surgescript) = %{ss_version} I'll reiterate what others have said: It'd be a much better idea to get this packaged separately and have Open Surge depend on it. > License: CC-BY-3.0 and CC-BY-SA-3.0 and CC-0 and Public Domain The license tag is "CC-BY and CC-BY-SA and CC0 and Public Domain" See: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses > %setup -q Use "%autosetup -p1" instead. > make %{?_smp_mflags} Use "%make_build" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
