https://bugzilla.redhat.com/show_bug.cgi?id=1823117 --- Comment #4 from Antonio T. (sagitter) <anto.trande@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Spec file name must match the spec package %{name}, in the format %{name}.spec. Note: opensurge-0.5.1.2-2.spec should be opensurge.spec See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_spec_file_naming - Source archives provide files under multiple licenses. Please, include all licenses and comment about which files are realased under such of them. - Why you don't package surgescript separately? ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GPL (v3 or later)", "*No copyright* Creative Commons Attribution Public License (v3.0)", "*No copyright* Apache License (v2.0)", "SIL Open Font License (v1.1)", "Expat License", "*No copyright* Creative Commons CC0 Public License (v1.0)", "Apache License (v2.0)", "*No copyright* Public domain", "*No copyright* do What The Fuck you want to Public License (v2)", "GNU Lesser General Public License (v2.1 or later)", "BSD (unspecified)", "BSD 2-clause "Simplified" License". 637 files have unknown license. Detailed output of licensecheck in /home/sagitter/1823117-opensurge-0.5.1.2-2/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in opensurge-data [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: opensurge-0.5.1.2-2.fc33.x86_64.rpm opensurge-data-0.5.1.2-2.fc33.noarch.rpm opensurge-debuginfo-0.5.1.2-2.fc33.x86_64.rpm opensurge-debugsource-0.5.1.2-2.fc33.x86_64.rpm opensurge-0.5.1.2-2.fc33.src.rpm opensurge.x86_64: W: spelling-error Summary(en_US) platformer -> platformed, plat former, plat-former opensurge.x86_64: W: spelling-error %description -l en_US platformer -> platformed, plat former, plat-former opensurge.x86_64: E: description-line-too-long C Open Surge is two projects in one: a game and a game creation system (game engine). opensurge.x86_64: W: no-documentation opensurge.x86_64: W: no-manual-page-for-binary opensurge opensurge-data.noarch: W: invalid-license CC-BY-3.0 opensurge-data.noarch: W: invalid-license CC-BY-SA-3.0 opensurge-data.noarch: W: invalid-license CC-0 opensurge-data.noarch: W: no-documentation opensurge-data.noarch: W: dangling-symlink /usr/share/opensurge/fonts/Roboto-Black.ttf /usr/share/fonts/google-roboto/Roboto-Black.ttf opensurge-data.noarch: W: dangling-symlink /usr/share/opensurge/fonts/Roboto-Bold.ttf /usr/share/fonts/google-roboto/Roboto-Bold.ttf opensurge-data.noarch: W: dangling-symlink /usr/share/opensurge/fonts/Roboto-Medium.ttf /usr/share/fonts/google-roboto/Roboto-Medium.ttf opensurge.src: W: spelling-error Summary(en_US) platformer -> platformed, plat former, plat-former opensurge.src: W: spelling-error %description -l en_US platformer -> platformed, plat former, plat-former opensurge.src: E: description-line-too-long C Open Surge is two projects in one: a game and a game creation system (game engine). opensurge.src:65: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 65) 5 packages and 0 specfiles checked; 2 errors, 14 warnings. Rpmlint (debuginfo) ------------------- Checking: opensurge-debuginfo-0.5.1.2-2.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). opensurge-debuginfo.x86_64: W: invalid-url URL: https://opensurge2d.org <urlopen error [Errno -2] Name or service not known> opensurge-debugsource.x86_64: W: invalid-url URL: https://opensurge2d.org <urlopen error [Errno -2] Name or service not known> opensurge-data.noarch: W: invalid-license CC-BY-3.0 opensurge-data.noarch: W: invalid-license CC-BY-SA-3.0 opensurge-data.noarch: W: invalid-license CC-0 opensurge-data.noarch: W: invalid-url URL: https://opensurge2d.org <urlopen error [Errno -2] Name or service not known> opensurge-data.noarch: W: no-documentation opensurge-data.noarch: W: dangling-symlink /usr/share/opensurge/fonts/Roboto-Black.ttf /usr/share/fonts/google-roboto/Roboto-Black.ttf opensurge-data.noarch: W: dangling-symlink /usr/share/opensurge/fonts/Roboto-Bold.ttf /usr/share/fonts/google-roboto/Roboto-Bold.ttf opensurge-data.noarch: W: dangling-symlink /usr/share/opensurge/fonts/Roboto-Medium.ttf /usr/share/fonts/google-roboto/Roboto-Medium.ttf opensurge.x86_64: W: spelling-error Summary(en_US) platformer -> platformed, plat former, plat-former opensurge.x86_64: W: spelling-error %description -l en_US platformer -> platformed, plat former, plat-former opensurge.x86_64: E: description-line-too-long C Open Surge is two projects in one: a game and a game creation system (game engine). opensurge.x86_64: W: invalid-url URL: https://opensurge2d.org <urlopen error [Errno -2] Name or service not known> opensurge.x86_64: W: no-documentation opensurge.x86_64: W: no-manual-page-for-binary opensurge 4 packages and 0 specfiles checked; 1 errors, 15 warnings. Source checksums ---------------- https://github.com/alemart/surgescript/archive/v0.5.4.3/surgescript-0.5.4.3.tar.gz : CHECKSUM(SHA256) this package : 52bb460b3a882788cc1001610d35f56a9c206b4f565db593a507f69862d6270c CHECKSUM(SHA256) upstream package : 52bb460b3a882788cc1001610d35f56a9c206b4f565db593a507f69862d6270c https://raw.githubusercontent.com/alemart/opensurge/1def8579e661e3128e495b7108a1988d40453a65/CMakeLists.txt : CHECKSUM(SHA256) this package : 53578904fde0199b5f32e8b036691faaa03453aea5893de61e5db5296b633268 CHECKSUM(SHA256) upstream package : 53578904fde0199b5f32e8b036691faaa03453aea5893de61e5db5296b633268 https://github.com/alemart/opensurge/archive/v0.5.1.2/opensurge-0.5.1.2.tar.gz : CHECKSUM(SHA256) this package : d060e3215231741ce0b4e5b897af52f8755c57660c8a33856bf921c83af18ba2 CHECKSUM(SHA256) upstream package : d060e3215231741ce0b4e5b897af52f8755c57660c8a33856bf921c83af18ba2 Requires -------- opensurge (rpmlib, GLIBC filtered): google-roboto-fonts liballegro.so.5.2()(64bit) liballegro_acodec.so.5.2()(64bit) liballegro_audio.so.5.2()(64bit) liballegro_dialog.so.5.2()(64bit) liballegro_font.so.5.2()(64bit) liballegro_image.so.5.2()(64bit) liballegro_memfile.so.5.2()(64bit) liballegro_primitives.so.5.2()(64bit) liballegro_ttf.so.5.2()(64bit) libc.so.6()(64bit) libm.so.6()(64bit) opensurge-data rtld(GNU_HASH) opensurge-data (rpmlib, GLIBC filtered): opensurge-debuginfo (rpmlib, GLIBC filtered): opensurge-debugsource (rpmlib, GLIBC filtered): Provides -------- opensurge: application() application(opensurge.desktop) bundled(surgescript) metainfo() metainfo(opensurge.appdata.xml) opensurge opensurge(x86-64) opensurge-data: opensurge-data opensurge-debuginfo: debuginfo(build-id) opensurge-debuginfo opensurge-debuginfo(x86-64) opensurge-debugsource: opensurge-debugsource opensurge-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1823117 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: SugarActivity, PHP, fonts, Java, Ocaml, Haskell, Python, Perl, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
