https://bugzilla.redhat.com/show_bug.cgi?id=1822971 --- Comment #3 from Nick Black <dank@xxxxxxxxx> --- Thanks for the review, Artur! I've made the requested changes; the updated spec file (in raw, non-rich format) can be found here: https://raw.githubusercontent.com/dankamongmen/notcurses/master/tools/notcurses.spec>%{python3_sitelib}/*egg-info/ > This should probably go in a separate package, like "python3-notcurses". Not everyone needs the python bindings. Done > Why are the tests disabled? Add a comment to the spec. Done. doctest is not present in F32, so far as I can tell. I considered downloading it at runtime or packaging it with notcurses, but given its presence in other targeted distributions, I decided to wait on it appearing in Fedora (or to package it for Fedora myself). > This should be an archful dependency - "%{name}%{?_isa} = %{version}-%{release}" Done. I've added a similar dependency to the new Python package. > Do not assume that man pages will be gzipped. Use a wildcard that can match any compression method Done. > Also, you list every file in the resulting package individually, but you do not list the directories. Done. That cleans up the file nicely, thanks. I've commited this to my git, and will test it now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
