https://bugzilla.redhat.com/show_bug.cgi?id=1822971 Artur Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #2 from Artur Iwicki <fedora@xxxxxxxxxx> --- >Spec URL: https://github.com/dankamongmen/notcurses/blob/master/tools/notcurses.spec This link points to a syntax-highlighted HTML view of the file. Please use a link to the raw file next time. >%package devel >Requires: %{name} = %{version}-%{release} This should be an archful dependency - "%{name}%{?_isa} = %{version}-%{release}" https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package >%build >%cmake -DUSE_FFMPEG=off -DUSE_TESTS=off . Why are the tests disabled? Add a comment to the spec. >%{python3_sitelib}/*egg-info/ This should probably go in a separate package, like "python3-notcurses". Not everyone needs the python bindings. >%{_mandir}/man1/notcurses-demo.1.gz >%{_mandir}/man1/notcurses-input.1.gz >... >%{_mandir}/man3/notcurses.3.gz >%{_mandir}/man3/notcurses_cell.3.gz >... Do not assume that man pages will be gzipped. Use a wildcard that can match any compression method (including no compression at all). https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages Also, you list every file in the resulting package individually, but you do not list the directories. This will cause RPM to consider the directories as unowned (not belonging to any package). You should add directories to the %files list. You can then also replace the list of files with a wildcard that matches all of them. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
