https://bugzilla.redhat.com/show_bug.cgi?id=1814682 Michal Schmidt <mschmidt@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags|fedora-review+ |fedora-review? --- Comment #31 from Michal Schmidt <mschmidt@xxxxxxxxxx> --- Thank you Honggang for the detailed review results. I disagree with the overall PASSED result, though the package is almost there. Liming, please fix this item flagged by fedora-review: > [!]: Uses parallel make %{?_smp_mflags} macro. The recommended fix is to use the "%make_build" macro. You still have this in the %install section: > %__spec_install_post Please remove it. About these BRs: > BuildRequires: systemd-units > BuildRequires: systemd-rpm-macros The first one seems unnecessary. systemd-rpm-macros should be sufficient. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
