https://bugzilla.redhat.com/show_bug.cgi?id=1814682 Honggang LI <honli@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #30 from Honggang LI <honli@xxxxxxxxxx> --- The srpm package PASSED review. Set the 'fedora-review+' flag for it. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. honli: PASS [ ]: Package contains no static executables. honli: PASS [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. honli: PASS. See next comment. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GPL (v2)", "Unknown or generated". 19 files have unknown license. Detailed output of licensecheck in /home/honli/1814682-rshim/licensecheck.txt honli: PASS. I had checked all files. Only three files do not have license tag. rshim-2.0.1/README.md, rshim-2.0.1/man/rshim.8, and rshim-2.0.1/bootstrap.sh does not have license tag. It is fine for the first two files as no one add license tag for such kind of files. rshim-2.0.1/bootstrap.sh is a dummy bash script. It is better to add a SPDX-License-Identifier in the head of it. But it is also acceptable to ignore it. [ ]: License file installed when any subpackage combination is installed. honli: PASS. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/systemd/system, /usr/lib/systemd honli: PASS. Both directories are co-own by many packages. [ ]: %build honors applicable compiler flags or justifies otherwise. honli: PASS. Default compiler flags used. [ ]: Package contains no bundled libraries without FPC exception. honli: PASS. No bundled library. [ ]: Changelog in prescribed format. honli: PASS [ ]: Sources contain only permissible code or content. honli: PASS [ ]: Package contains desktop file if it is a GUI application. honli: PASS. No desktop file. [ ]: Development files must be in a -devel package honli: PASS. No development files. [ ]: Package uses nothing in %doc for runtime. honli: PASS. [ ]: Package consistently uses macros (instead of hard-coded directory names). honli: PASS [ ]: Package is named according to the Package Naming Guidelines. honli: PASS [ ]: Package does not generate any conflict. honli: PASS [ ]: Package obeys FHS, except libexecdir and /usr/target. honli: PASS [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. honli: PASS [ ]: Requires correct, justified where necessary. honli: PASS [ ]: Spec file is legible and written in American English. honli: PASS [ ]: Package contains systemd file(s) if in need. honli: PASS [ ]: Useful -debuginfo package or justification otherwise. honli: PASS [ ]: Package is not known to require an ExcludeArch tag. honli: PASS [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. honli: PASS [ ]: Package complies to the Packaging Guidelines honli: PASS [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in rshim [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. honli: PASS. Because the source tarball just has a few C files. That means it can be compiled in about one minute. It is OK for this package to ignore parallel compilation. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. honli: PASS. It is has a separate license file. [ ]: Final provides and requires are sane (see attachments). honli: PASS. [ ]: Package functions as described. honli: PASS. We could not get the hardware in time, so we will ask Mellanox to test this. After this package get into RHEL, Redhat QE will test it for RHEL. [ ]: Latest version is packaged. honli: PASS [ ]: Package does not include license text files separate from upstream. honli: PASS [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. honli: PASS [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. honli: PASS [ ]: Package should compile and build into binary rpms on all supported architectures. honli: PASS [ ]: %check is present and all tests pass. honli: PASS [ ]: Packages should try to preserve timestamps of original installed files. honli: PASS [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rshim-2.0.1-1.fc33.x86_64.rpm rshim-debuginfo-2.0.1-1.fc33.x86_64.rpm rshim-debugsource-2.0.1-1.fc33.x86_64.rpm rshim-2.0.1-1.fc33.src.rpm 4 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (debuginfo) ------------------- Checking: rshim-debuginfo-2.0.1-1.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- rshim-debugsource.x86_64: W: invalid-url URL: https://github.com/mellanox/rshim-user-space <urlopen error [Errno -2] Name or service not known> rshim-debuginfo.x86_64: W: invalid-url URL: https://github.com/mellanox/rshim-user-space <urlopen error [Errno -2] Name or service not known> rshim.x86_64: W: invalid-url URL: https://github.com/mellanox/rshim-user-space <urlopen error [Errno -2] Name or service not known> 3 packages and 0 specfiles checked; 0 errors, 3 warnings. honli: PASS. I'm pretty sure those URL are valid. It is a fedora-review tool issue for those false positive. Source checksums ---------------- https://github.com/Mellanox/rshim-user-space/releases/download/rshim-2.0.1/rshim-2.0.1.tar.gz : CHECKSUM(SHA256) this package : 57c9055df902d55ad990d3209e0c190f9c4d9087726bad31afd457bd95bcba80 CHECKSUM(SHA256) upstream package : 57c9055df902d55ad990d3209e0c190f9c4d9087726bad31afd457bd95bcba80 Requires -------- rshim (rpmlib, GLIBC filtered): /bin/sh libc.so.6()(64bit) libfuse.so.2()(64bit) libfuse.so.2(FUSE_2.4)(64bit) libfuse.so.2(FUSE_2.5)(64bit) libfuse.so.2(FUSE_2.8)(64bit) libpci.so.3()(64bit) libpci.so.3(LIBPCI_3.0)(64bit) libpci.so.3(LIBPCI_3.5)(64bit) libpthread.so.0()(64bit) libusb-1.0.so.0()(64bit) rtld(GNU_HASH) rshim-debuginfo (rpmlib, GLIBC filtered): rshim-debugsource (rpmlib, GLIBC filtered): Provides -------- rshim: rshim rshim(x86-64) rshim-debuginfo: debuginfo(build-id) rshim-debuginfo rshim-debuginfo(x86-64) rshim-debugsource: rshim-debugsource rshim-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1814682 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Haskell, Ruby, PHP, Ocaml, Java, R, SugarActivity, Perl, fonts, Python Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
