Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Mail-DKIM - Perl module for DKIM support https://bugzilla.redhat.com/show_bug.cgi?id=250634 cweyl@xxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cweyl@xxxxxxxxxxxxxxx ------- Additional Comments From cweyl@xxxxxxxxxxxxxxx 2007-10-17 12:01 EST ------- A couple comments from looking at the spec file: Perl deps are specified by module, rather than by the name of the package that provides the required module. e.g., where your package buildrequires perl-ExtUtils-MakeMaker, it should buildrequire perl(ExtUtils::MakeMaker) instead. See https://fedoraproject.org/wiki/PackagingDrafts/Perl#requiresandprovides There look to be a number of files ripe for inclusion in %doc, namely README, Change*, HACKING.dkim, scripts/, t/, etc, etc; why not include those in %doc? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review