https://bugzilla.redhat.com/show_bug.cgi?id=1819072 --- Comment #2 from Florian Müllner <fmuellner@xxxxxxxxxx> --- (In reply to Kalev Lember from comment #1) > Packaging looks nice and clean. Some notes: > > $ rpmlint gnome-extensions-app-3.36.1-1.fc32.src.rpm \ > gnome-extensions-app-3.36.1-1.fc32.x86_64.rpm Meh, I should have thought of running that myself. > gnome-extensions-app.src:20: W: mixed-use-of-spaces-and-tabs (spaces: line > 20, tab: line 4) Fixed. > gnome-extensions-app.x86_64: W: no-documentation > gnome-extensions-app.x86_64: W: no-manual-page-for-binary > gnome-shell-extension-prefs Any chance to shut those up? I'm not going to waste time adding a man page for a graphical application ... (I know you didn't ask me to fix those, just curious) > > License: GPLv3+ > > Is GPLv3+ correct? README and COPYING seem to indicate it's GPL version 2. Yikes, good catch. gnome-extensions-tool is GPL3, and that's the spec I copied because I had figured out the building-from-subproject stuff. Fixed. > Can you add appdata validation as per > https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ > #_app_data_validate_usage ? Done. I guess an alternative would be to run %meson_check (which performs that check if appstream-util is available)? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
