[Bug 1819072] Review Request: gnome-extensions-app - gnome-shell extensions management

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1819072



--- Comment #1 from Kalev Lember <klember@xxxxxxxxxx> ---
Packaging looks nice and clean. Some notes:

$ rpmlint gnome-extensions-app-3.36.1-1.fc32.src.rpm \
          gnome-extensions-app-3.36.1-1.fc32.x86_64.rpm

gnome-extensions-app.src:20: W: mixed-use-of-spaces-and-tabs (spaces: line 20,
tab: line 4)
gnome-extensions-app.x86_64: W: no-documentation
gnome-extensions-app.x86_64: W: no-manual-page-for-binary
gnome-shell-extension-prefs
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

Can you fix the mixed-use-of-spaces-and-tabs warning from above?

> License:	GPLv3+

Is GPLv3+ correct? README and COPYING seem to indicate it's GPL version 2.

Can you add appdata validation as per
https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage
?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux