https://bugzilla.redhat.com/show_bug.cgi?id=1813406 --- Comment #2 from Scott Talbert <swt@xxxxxxxxxx> --- Thanks (again!), Robert-André! (In reply to Robert-André Mauchin from comment #1) > - %makeinstall is deprecated, you should use %make_install Fixed. > - license files must be installed with %license not %doc Fixed. > Issues: > ======= > - If (and only if) the source package includes the text of the license(s) > in its own file, then that file, containing the text of the license(s) > for the package is included in %license. > Note: License file licence.txt is not marked as %license > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/LicensingGuidelines/#_license_text Fixed. > - Package does not use a name that already exists. > Note: A package with this name already exists. Please check > https://src.fedoraproject.org/rpms/wxGTK > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/Naming/#_conflicting_package_names This is intentional. The wxGTK package used to be wxWidgets 2.8, but it was retired when all users moved to wxWidgets 3.0, which is the wxGTK3 package. In this new review, I'm packaging wxWidgets 3.1. The intention is that wxGTK package would now follow the main development releases of wxWidgets and when a stable release is broken off, that would be package separately (e.g., when 3.2 comes out, it would be packaged as wxGTK32, and wxGTK would then follow 3.3). > wxGTK.x86_64: E: incorrect-fsf-address /usr/share/doc/wxGTK/gpl.txt > wxGTK.x86_64: E: incorrect-fsf-address /usr/share/doc/wxGTK/lgpl.txt > wxBase.x86_64: E: incorrect-fsf-address /usr/share/doc/wxBase/gpl.txt > wxBase.x86_64: E: incorrect-fsf-address /usr/share/doc/wxBase/lgpl.txt Fixed these also. Same spec/RPM locations. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
