[Bug 1813406] Review Request: wxGTK - GTK port of the wxWidgets GUI library (dev version)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1813406

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebob.m@xxxxxxxxx
           Doc Type|---                         |If docs needed, set a value



--- Comment #1 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
 - %makeinstall is deprecated, you should use %make_install

 - license files must be installed with %license not %doc

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file licence.txt is not marked as %license
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/LicensingGuidelines/#_license_text
- Package does not use a name that already exists.
  Note: A package with this name already exists. Please check
  https://src.fedoraproject.org/rpms/wxGTK
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/Naming/#_conflicting_package_names


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "NTP License", "GNU Lesser General
     Public License", "GPL (v2 or later) GNU Lesser General Public License
     (v2 or later)", "GNU Lesser General Public License (v2)", "*No
     copyright* Boost Software License 1.0", "GPL (v2 or later)", "FSF All
     Permissive License", "Expat License", "FSF Unlimited License (with
     Retention)", "GNU Lesser General Public License (v2 or later)", "*No
     copyright* Public domain", "zlib/libpng license", "Boost Software
     License 1.0", "BSD 2-clause "Simplified" License", "GPL (v2 or later)
     (with incorrect FSF address)", "Apache License 2.0", "Unicode strict",
     "Khronos License", "FSF Unlimited License (with Retention) GNU General
     Public License (v2)", "BSD 3-clause "New" or "Revised" License", "GPL
     (v3 or later)", "*No copyright* GNU Free Documentation License
     (v1.1)", "Public domain". 7656 files have unknown license. Detailed
     output of licensecheck in /home/bob/packaging/review/wxGTK/review-
     wxGTK/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib64/wx(wxGTK3-webview,
     wxBase3-devel), /usr/lib64/wx/config(wxBase3-devel),
     /usr/lib64/wx/include(wxBase3-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in wxBase-
     devel , wxGTK-gl , wxGTK-i18n , wxGTK-media , wxGTK-webview , wxBase ,
     wxGTK-docs
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[x]: Scriptlets must be sane, if used.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: wxGTK-3.1.3-1.fc33.x86_64.rpm
          wxBase-devel-3.1.3-1.fc33.x86_64.rpm
          wxGTK-devel-3.1.3-1.fc33.x86_64.rpm
          wxGTK-gl-3.1.3-1.fc33.x86_64.rpm
          wxGTK-i18n-3.1.3-1.fc33.noarch.rpm
          wxGTK-media-3.1.3-1.fc33.x86_64.rpm
          wxGTK-webview-3.1.3-1.fc33.x86_64.rpm
          wxBase-3.1.3-1.fc33.x86_64.rpm
          wxGTK-docs-3.1.3-1.fc33.noarch.rpm
          wxGTK-debuginfo-3.1.3-1.fc33.x86_64.rpm
          wxGTK-debugsource-3.1.3-1.fc33.x86_64.rpm
          wxGTK-3.1.3-1.fc33.src.rpm
wxGTK.x86_64: E: shared-lib-without-dependency-information
/usr/lib64/libwx_gtk3u_adv-3.1.so.3.0.0
wxGTK.x86_64: E: incorrect-fsf-address /usr/share/doc/wxGTK/gpl.txt
wxGTK.x86_64: E: incorrect-fsf-address /usr/share/doc/wxGTK/lgpl.txt
wxBase-devel.x86_64: W: spelling-error %description -l en_US wxWidgets ->
widgets
wxBase-devel.x86_64: W: no-documentation
wxBase-devel.x86_64: W: non-executable-in-bin /usr/bin/wx-config 644
wxBase-devel.x86_64: W: non-executable-in-bin /usr/bin/wxrc 644
wxBase-devel.x86_64: W: no-manual-page-for-binary wx-config-3.1
wxBase-devel.x86_64: W: no-manual-page-for-binary wxrc-3.1
wxBase-devel.x86_64: W: dangerous-command-in-%post rm
wxGTK-devel.x86_64: W: spelling-error %description -l en_US wxWidgets ->
widgets
wxGTK-devel.x86_64: W: no-documentation
wxGTK-gl.x86_64: W: spelling-error Summary(en_US) wxWidgets -> widgets
wxGTK-gl.x86_64: W: spelling-error %description -l en_US wxWidgets -> widgets
wxGTK-gl.x86_64: W: no-documentation
wxGTK-i18n.noarch: W: spelling-error Summary(en_US) wxWidgets -> widgets
wxGTK-i18n.noarch: W: summary-not-capitalized C i18n message catalogs for the
wxWidgets library
wxGTK-i18n.noarch: W: spelling-error %description -l en_US wxWidgets -> widgets
wxGTK-i18n.noarch: W: no-documentation
wxGTK-media.x86_64: W: spelling-error Summary(en_US) wxWidgets -> widgets
wxGTK-media.x86_64: W: spelling-error %description -l en_US wxWidgets ->
widgets
wxGTK-media.x86_64: W: no-documentation
wxGTK-webview.x86_64: W: spelling-error Summary(en_US) wxWidgets -> widgets
wxGTK-webview.x86_64: W: spelling-error %description -l en_US wxWidgets ->
widgets
wxGTK-webview.x86_64: W: no-documentation
wxBase.x86_64: W: spelling-error Summary(en_US) wxWidgets -> widgets
wxBase.x86_64: W: spelling-error %description -l en_US wxWidgets -> widgets
wxBase.x86_64: W: spelling-error %description -l en_US wxString -> stringing,
string
wxBase.x86_64: E: incorrect-fsf-address /usr/share/doc/wxBase/gpl.txt
wxBase.x86_64: E: incorrect-fsf-address /usr/share/doc/wxBase/lgpl.txt
wxGTK-docs.noarch: W: spelling-error %description -l en_US wxWidgets -> widgets
wxGTK.src: W: spelling-error Summary(en_US) wxWidgets -> widgets
wxGTK.src: W: spelling-error %description -l en_US wxWidgets -> widgets
wxGTK.src:169: W: configure-without-libdir-spec
12 packages and 0 specfiles checked; 5 errors, 29 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux