https://bugzilla.redhat.com/show_bug.cgi?id=1353169 Neal Gompa <ngompa13@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ngompa13@xxxxxxxx |needinfo?(jamatos@xxxxxxxx) |m) | --- Comment #43 from Neal Gompa <ngompa13@xxxxxxxxx> --- (In reply to José Matos from comment #42) > Hi Neal, > > what is missing in this review? > > > FWIW in my todo list there is just a small issue, that can be done at ay > time. > According to nikola's source: > > """ > We ship some third-party things with Nikola. They live here, along with > their > licenses. > > Packages: > > * tzlocal by Lennart Regebro, CC0 license (modified) > * datecond by Chris Warrick (Nikola contributor), 3-clause BSD license > (modified) > """ > > The second is very small and from one of nikola's main contributors. > I asked about tzlocal and it can be done, with just a small change, either by > using the system tzlocal and by changing to pytz: > https://groups.google.com/forum/#!topic/nikola-discuss/3vXZFJF_-h4 Please document the bundled dependencies and their versions and why, per the policy. Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling Cf. https://fedoraproject.org/wiki/Bundled_Libraries#Requirement_if_you_bundle I would prefer to see tzlocal unbundled, though I can accept this upstream preferring otherwise as long as it is documented properly. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
