https://bugzilla.redhat.com/show_bug.cgi?id=1808878 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Jerry James <loganjerry@xxxxxxxxx> --- Okay, that looks good. I have one final suggestion, which you are free to ignore: do not remove objects.inv. That file is used by sphinx to create cross-links between documentation for different modules. If some other python module someday wants to refer to the eccodes documentation, it will need objects.inv to do so. Of course, there may not be any such python module, so I'm leaving this up to you. This package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
