https://bugzilla.redhat.com/show_bug.cgi?id=1808878 --- Comment #4 from Jos de Kloe <josdekloe@xxxxxxxxx> --- Thanks for being thorough as well! My next attempt is here: Spec URL: http://www.jdekloe.nl/Fedora/python-eccodes-rev2/python-eccodes.spec SRPM URL: http://www.jdekloe.nl/Fedora/python-eccodes-rev2/python-eccodes-0.9.7-1.fc31.src.rpm My responses to your issues are: 1. License file is missing. Add this to %files: %license LICENSE done 2. The __provides_exclude_from setting at the top of the spec file is not necessary. RPM already filters out that directory. removed 3. The formatting of %_description seems odd. corrected 4. As Emanuele pointed out, "BuildRequires: eccodes" is not necessary. removed 5. Remove "Requires: eccodes" from the python3 package. removed 6. Do not use the %{__mv} and %{__rm} macros. corrected 7. The mv command in %install does not work on 32-bit platforms... I think it would be better to patch setup.py so that it installs into the architecture-specific directory in the first place. I patched the setup file 8. Have you thought about using the pyproject macros? See https://src.fedoraproject.org/rpms/pyproject-rpm-macros. At least, the %tox macro could be used in %check. I tried it for %check, but could not get %tox to work. I am not familiar with tox, but it seems that the tox config files do not yet account for python version 3.8 as used in rawhide. 9. Have you considered building the documentation with sphinx? added sphinx documentaiton generation 10. Version 0.9.5 is not the latest version. Version 0.9.7 has been released. moved to the latest release. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
